Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 76027
b: refs/heads/master
c: e589665
h: refs/heads/master
i:
  76025: de9ad3e
  76023: ce9abc7
v: v3
  • Loading branch information
Steven Whitehouse committed Jan 25, 2008
1 parent e67d87d commit 6421537
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 20 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 3042a2ccd68d2b609d283219e51cba363aa35c1d
refs/heads/master: e589665eb97b297412fb16b4c1737a01a91db903
17 changes: 2 additions & 15 deletions trunk/fs/gfs2/glock.c
Original file line number Diff line number Diff line change
Expand Up @@ -594,12 +594,7 @@ static void run_queue(struct gfs2_glock *gl)
if (!list_empty(&gl->gl_waiters1)) {
gh = list_entry(gl->gl_waiters1.next,
struct gfs2_holder, gh_list);

if (test_bit(HIF_MUTEX, &gh->gh_iflags))
blocked = rq_mutex(gh);
else
gfs2_assert_warn(gl->gl_sbd, 0);

blocked = rq_mutex(gh);
} else if (test_bit(GLF_DEMOTE, &gl->gl_flags)) {
blocked = rq_demote(gl);
if (gl->gl_waiters2 && !blocked) {
Expand All @@ -610,12 +605,7 @@ static void run_queue(struct gfs2_glock *gl)
} else if (!list_empty(&gl->gl_waiters3)) {
gh = list_entry(gl->gl_waiters3.next,
struct gfs2_holder, gh_list);

if (test_bit(HIF_PROMOTE, &gh->gh_iflags))
blocked = rq_promote(gh);
else
gfs2_assert_warn(gl->gl_sbd, 0);

blocked = rq_promote(gh);
} else
break;

Expand All @@ -636,7 +626,6 @@ static void gfs2_glmutex_lock(struct gfs2_glock *gl)
struct gfs2_holder gh;

gfs2_holder_init(gl, 0, 0, &gh);
set_bit(HIF_MUTEX, &gh.gh_iflags);
if (test_and_set_bit(HIF_WAIT, &gh.gh_iflags))
BUG();

Expand Down Expand Up @@ -1160,8 +1149,6 @@ int gfs2_glock_nq(struct gfs2_holder *gh)
return -EIO;
}

set_bit(HIF_PROMOTE, &gh->gh_iflags);

spin_lock(&gl->gl_spin);
add_to_queue(gh);
run_queue(gl);
Expand Down
4 changes: 0 additions & 4 deletions trunk/fs/gfs2/incore.h
Original file line number Diff line number Diff line change
Expand Up @@ -141,10 +141,6 @@ struct gfs2_glock_operations {
};

enum {
/* Actions */
HIF_MUTEX = 0,
HIF_PROMOTE = 1,

/* States */
HIF_HOLDER = 6,
HIF_FIRST = 7,
Expand Down

0 comments on commit 6421537

Please sign in to comment.