Skip to content

Commit

Permalink
mfd: Support configurable numbers of DCDCs and ISINKs on WM8350
Browse files Browse the repository at this point in the history
Some WM8350 variants have fewer DCDCs and ISINKs. Identify these at
probe and refuse to use the absent DCDCs when running on these chips.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Samuel Ortiz <sameo@openedhand.com>
  • Loading branch information
Mark Brown authored and Samuel Ortiz committed Jan 4, 2009
1 parent 53a0d99 commit 645524a
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 0 deletions.
6 changes: 6 additions & 0 deletions drivers/mfd/wm8350-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -1301,6 +1301,9 @@ int wm8350_device_init(struct wm8350 *wm8350, int irq,

switch (mask_rev) {
case 0:
wm8350->pmic.max_dcdc = WM8350_DCDC_6;
wm8350->pmic.max_isink = WM8350_ISINK_B;

switch (chip_rev) {
case WM8350_REV_E:
dev_info(wm8350->dev, "WM8350 Rev E\n");
Expand All @@ -1325,6 +1328,9 @@ int wm8350_device_init(struct wm8350 *wm8350, int irq,
break;

case 2:
wm8350->pmic.max_dcdc = WM8350_DCDC_6;
wm8350->pmic.max_isink = WM8350_ISINK_B;

switch (chip_rev) {
case 0:
dev_info(wm8350->dev, "WM8352 Rev A\n");
Expand Down
7 changes: 7 additions & 0 deletions drivers/regulator/wm8350-regulator.c
Original file line number Diff line number Diff line change
Expand Up @@ -1380,6 +1380,13 @@ int wm8350_register_regulator(struct wm8350 *wm8350, int reg,
if (wm8350->pmic.pdev[reg])
return -EBUSY;

if (reg >= WM8350_DCDC_1 && reg <= WM8350_DCDC_6 &&
reg > wm8350->pmic.max_dcdc)
return -ENODEV;
if (reg >= WM8350_ISINK_A && reg <= WM8350_ISINK_B &&
reg > wm8350->pmic.max_isink)
return -ENODEV;

pdev = platform_device_alloc("wm8350-regulator", reg);
if (!pdev)
return -ENOMEM;
Expand Down
4 changes: 4 additions & 0 deletions include/linux/mfd/wm8350/pmic.h
Original file line number Diff line number Diff line change
Expand Up @@ -701,6 +701,10 @@ struct platform_device;
struct regulator_init_data;

struct wm8350_pmic {
/* Number of regulators of each type on this device */
int max_dcdc;
int max_isink;

/* ISINK to DCDC mapping */
int isink_A_dcdc;
int isink_B_dcdc;
Expand Down

0 comments on commit 645524a

Please sign in to comment.