Skip to content

Commit

Permalink
[NET_SCHED]: sch_ingress: move dependencies to Kconfig
Browse files Browse the repository at this point in the history
Instead of complaining at scheduler initialization time, check the
dependencies in Kconfig.

Signed-off-by: Patrick McHardy <kaber@trash.net>
Acked-by: Jamal Hadi Salim <hadi@cyberus.ca>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Patrick McHardy authored and David S. Miller committed Jan 28, 2008
1 parent c6ee877 commit 645a1e3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 10 deletions.
1 change: 1 addition & 0 deletions net/sched/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,7 @@ config NET_SCH_NETEM

config NET_SCH_INGRESS
tristate "Ingress Qdisc"
depends on NET_CLS_ACT || NETFILTER
---help---
Say Y here if you want to use classifiers for incoming packets.
If unsure, say Y.
Expand Down
11 changes: 1 addition & 10 deletions net/sched/sch_ingress.c
Original file line number Diff line number Diff line change
Expand Up @@ -162,19 +162,10 @@ static struct nf_hook_ops ing_ops[] __read_mostly = {

static int ingress_init(struct Qdisc *sch, struct rtattr *opt)
{
/* Make sure either netfilter or preferably CLS_ACT is
* compiled in */
#ifndef CONFIG_NET_CLS_ACT
#ifndef CONFIG_NETFILTER
printk("You MUST compile classifier actions into the kernel\n");
return -EINVAL;
#else
#ifdef CONFIG_NETFILTER
printk("Ingress scheduler: Classifier actions prefered over netfilter\n");
#endif
#endif

#ifndef CONFIG_NET_CLS_ACT
#ifdef CONFIG_NETFILTER
if (!nf_registered) {
if (nf_register_hooks(ing_ops, ARRAY_SIZE(ing_ops)) < 0) {
printk("ingress qdisc registration error \n");
Expand Down

0 comments on commit 645a1e3

Please sign in to comment.