Skip to content

Commit

Permalink
ASoC: txx9aclc: dynamically allocate dmaengine devname
Browse files Browse the repository at this point in the history
Use kasprintf to allocate temporary devname string instead of a
fixed size string.
This fixes "FIXME" introduced on removal of BUS_ID_SIZE.

Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
  • Loading branch information
Atsushi Nemoto authored and Mark Brown committed Jun 25, 2009
1 parent 62b1653 commit 647613e
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions sound/soc/txx9/txx9aclc.c
Original file line number Diff line number Diff line change
Expand Up @@ -297,15 +297,17 @@ static int txx9aclc_pcm_new(struct snd_card *card, struct snd_soc_dai *dai,
static bool filter(struct dma_chan *chan, void *param)
{
struct txx9aclc_dmadata *dmadata = param;
char devname[20 + 2]; /* FIXME: old BUS_ID_SIZE + 2 */
char *devname;
bool found = false;

snprintf(devname, sizeof(devname), "%s.%d", dmadata->dma_res->name,
devname = kasprintf(GFP_KERNEL, "%s.%d", dmadata->dma_res->name,
(int)dmadata->dma_res->start);
if (strcmp(dev_name(chan->device->dev), devname) == 0) {
chan->private = &dmadata->dma_slave;
return true;
found = true;
}
return false;
kfree(devname);
return found;
}

static int txx9aclc_dma_init(struct txx9aclc_soc_device *dev,
Expand Down

0 comments on commit 647613e

Please sign in to comment.