Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 339447
b: refs/heads/master
c: b870553
h: refs/heads/master
i:
  339445: 7a31655
  339443: 670d829
  339439: cac0505
v: v3
  • Loading branch information
Dave Chinner authored and Ben Myers committed Nov 29, 2012
1 parent 4fb91ee commit 648d036
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 9 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 437a255aa23766666aec78af63be4c253faa8d57
refs/heads/master: b870553cdecb26d5291af09602352b763e323df2
15 changes: 7 additions & 8 deletions trunk/fs/xfs/xfs_qm.c
Original file line number Diff line number Diff line change
Expand Up @@ -1456,7 +1456,7 @@ xfs_qm_dqreclaim_one(
int error;

if (!xfs_dqlock_nowait(dqp))
goto out_busy;
goto out_move_tail;

/*
* This dquot has acquired a reference in the meantime remove it from
Expand All @@ -1479,7 +1479,7 @@ xfs_qm_dqreclaim_one(
* getting flushed to disk, we don't want to reclaim it.
*/
if (!xfs_dqflock_nowait(dqp))
goto out_busy;
goto out_unlock_move_tail;

if (XFS_DQ_IS_DIRTY(dqp)) {
struct xfs_buf *bp = NULL;
Expand All @@ -1490,7 +1490,7 @@ xfs_qm_dqreclaim_one(
if (error) {
xfs_warn(mp, "%s: dquot %p flush failed",
__func__, dqp);
goto out_busy;
goto out_unlock_move_tail;
}

xfs_buf_delwri_queue(bp, buffer_list);
Expand All @@ -1499,7 +1499,7 @@ xfs_qm_dqreclaim_one(
* Give the dquot another try on the freelist, as the
* flushing will take some time.
*/
goto out_busy;
goto out_unlock_move_tail;
}
xfs_dqfunlock(dqp);

Expand All @@ -1518,14 +1518,13 @@ xfs_qm_dqreclaim_one(
XFS_STATS_INC(xs_qm_dqreclaims);
return;

out_busy:
xfs_dqunlock(dqp);

/*
* Move the dquot to the tail of the list so that we don't spin on it.
*/
out_unlock_move_tail:
xfs_dqunlock(dqp);
out_move_tail:
list_move_tail(&dqp->q_lru, &qi->qi_lru_list);

trace_xfs_dqreclaim_busy(dqp);
XFS_STATS_INC(xs_qm_dqreclaim_misses);
}
Expand Down

0 comments on commit 648d036

Please sign in to comment.