Skip to content

Commit

Permalink
mips: take the "zero newsp means inherit the parent's one" to copy_th…
Browse files Browse the repository at this point in the history
…read()

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
  • Loading branch information
Al Viro committed Feb 3, 2013
1 parent 974fdb3 commit 64b3122
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 6 deletions.
2 changes: 0 additions & 2 deletions arch/mips/kernel/linux32.c
Original file line number Diff line number Diff line change
Expand Up @@ -289,8 +289,6 @@ _sys32_clone(nabi_no_regargs struct pt_regs regs)

clone_flags = regs.regs[4];
newsp = regs.regs[5];
if (!newsp)
newsp = regs.regs[29];
parent_tidptr = (int __user *) regs.regs[6];

/* Use __dummy4 instead of getting it off the stack, so that
Expand Down
3 changes: 2 additions & 1 deletion arch/mips/kernel/process.c
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,8 @@ int copy_thread(unsigned long clone_flags, unsigned long usp,
*childregs = *regs;
childregs->regs[7] = 0; /* Clear error flag */
childregs->regs[2] = 0; /* Child gets zero as return value */
childregs->regs[29] = usp;
if (usp)
childregs->regs[29] = usp;
ti->addr_limit = USER_DS;

p->thread.reg29 = (unsigned long) childregs;
Expand Down
4 changes: 1 addition & 3 deletions arch/mips/kernel/syscall.c
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ save_static_function(sys_fork);
static int __used noinline
_sys_fork(nabi_no_regargs struct pt_regs regs)
{
return do_fork(SIGCHLD, regs.regs[29], 0, NULL, NULL);
return do_fork(SIGCHLD, 0, 0, NULL, NULL);
}

save_static_function(sys_clone);
Expand All @@ -99,8 +99,6 @@ _sys_clone(nabi_no_regargs struct pt_regs regs)

clone_flags = regs.regs[4];
newsp = regs.regs[5];
if (!newsp)
newsp = regs.regs[29];
parent_tidptr = (int __user *) regs.regs[6];
#ifdef CONFIG_32BIT
/* We need to fetch the fifth argument off the stack. */
Expand Down

0 comments on commit 64b3122

Please sign in to comment.