Skip to content

Commit

Permalink
cxgb4vf: Remove obsolete comment about the lack of a TX Timer Callback
Browse files Browse the repository at this point in the history
Remove obsolete comment about the lack of a TX Timer Callback -- which
we now _do_ have ...

Signed-off-by: Casey Leedom <leedom@chelsio.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Casey Leedom authored and David S. Miller committed Jun 30, 2010
1 parent d6bebca commit 64bb336
Showing 1 changed file with 1 addition and 12 deletions.
13 changes: 1 addition & 12 deletions drivers/net/cxgb4vf/sge.c
Original file line number Diff line number Diff line change
Expand Up @@ -1301,18 +1301,7 @@ int t4vf_eth_xmit(struct sk_buff *skb, struct net_device *dev)
* wait for acks to really free up the data the extra memory
* is even less. On the positive side we run the destructors
* on the sending CPU rather than on a potentially different
* completing CPU, usually a good thing. We also run them
* without holding our TX queue lock, unlike what
* reclaim_completed_tx() would otherwise do.
*
* XXX Actually the above is somewhat incorrect since we don't
* XXX yet have a periodic timer which reclaims TX Descriptors.
* XXX What's our plan for this?
* XXX
* XXX Also, we don't currently have a TX Queue lock but
* XXX that may be the result of not having any current
* XXX asynchronous path for reclaiming completed TX
* XXX Descriptors ...
* completing CPU, usually a good thing.
*
* Run the destructor before telling the DMA engine about the
* packet to make sure it doesn't complete and get freed
Expand Down

0 comments on commit 64bb336

Please sign in to comment.