Skip to content

Commit

Permalink
staging: slicoss: return early before calling request_firmware with e…
Browse files Browse the repository at this point in the history
…mpty firmware filename

when the device id doesn't match in slic_card_download_gbrcv the filename is "",
i.e an empty name, and we try calling request_firmware with that name,
actually we can just fail out at default case before even calling request_firmware

Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Devendra Naga authored and Greg Kroah-Hartman committed Sep 4, 2012
1 parent 623c2bb commit 651d4bc
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/staging/slicoss/slicoss.c
Original file line number Diff line number Diff line change
Expand Up @@ -514,8 +514,7 @@ static int slic_card_download_gbrcv(struct adapter *adapter)
file = "slicoss/gbrcvucode.sys";
break;
default:
ASSERT(0);
break;
return -ENOENT;
}

ret = request_firmware(&fw, file, &adapter->pcidev->dev);
Expand Down

0 comments on commit 651d4bc

Please sign in to comment.