Skip to content

Commit

Permalink
ieee1394: add comments in struct hpsb_packet
Browse files Browse the repository at this point in the history
to clarify who is supposed to set what

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
  • Loading branch information
Stefan Richter committed Jul 9, 2007
1 parent 17a6248 commit 6552731
Showing 1 changed file with 7 additions and 3 deletions.
10 changes: 7 additions & 3 deletions drivers/ieee1394/ieee1394_core.h
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ struct hpsb_packet {
hpsb_unused, hpsb_queued, hpsb_pending, hpsb_complete
} __attribute__((packed)) state;

/* These are core internal. */
/* These are core-internal. */
signed char tlabel;
signed char ack_code;
unsigned char tcode;
Expand All @@ -62,11 +62,15 @@ struct hpsb_packet {
/* Store jiffies for implementing bus timeouts. */
unsigned long sendtime;

/* Sizes are in bytes. *data can be DMA-mapped. */
/* Core-internal. */
size_t allocated_data_size; /* as allocated */

/* Sizes are in bytes. To be set by caller of hpsb_alloc_packet. */
size_t data_size; /* as filled in */
size_t header_size; /* as filled in, not counting the CRC */
quadlet_t *data;

/* Buffers */
quadlet_t *data; /* can be DMA-mapped */
quadlet_t header[5];
quadlet_t embedded_data[0]; /* keep as last member */
};
Expand Down

0 comments on commit 6552731

Please sign in to comment.