---

yaml --- r: 357860 b: refs/heads/master c: 8dcf015 h: refs/heads/master v: v3
git-mirror · Nov 29, 2012 · 655dd24 · 655dd24
1 parent 413b6c7
commit 655dd24
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/[refs] b/[refs]
@@ -1,2 +1,2 @@
 ---
-refs/heads/master: a39a68054f63da0ea3b4806e1bfad79670a93d9f
+refs/heads/master: 8dcf015eb967c718962c0690330d9a94d56f2c5d
diff --git a/trunk/drivers/gpu/drm/i915/i915_gem.c b/trunk/drivers/gpu/drm/i915/i915_gem.c
@@ -830,9 +830,13 @@ i915_gem_shmem_pwrite(struct drm_device *dev,
 	i915_gem_object_unpin_pages(obj);
 
 	if (hit_slowpath) {
-		/* Fixup: Flush dirty cachelines in case the object isn't in the
-		 * cpu write domain anymore. */
-		if (obj->base.write_domain != I915_GEM_DOMAIN_CPU) {
+		/*
+		 * Fixup: Flush cpu caches in case we didn't flush the dirty
+		 * cachelines in-line while writing and the object moved
+		 * out of the cpu write domain while we've dropped the lock.
+		 */
+		if (!needs_clflush_after &&
+		    obj->base.write_domain != I915_GEM_DOMAIN_CPU) {
 			i915_gem_clflush_object(obj);
 			i915_gem_chipset_flush(dev);
 		}