Skip to content

Commit

Permalink
[XFS] fix spurious gcc warnings
Browse files Browse the repository at this point in the history
Some recent gcc warnings don't like passing string variables to
printf-like functions without using at least a "%s" format string.
Change the two occurances of that in xfs to please gcc.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Eric Sandeen <sandeen@sandeen.net>
Signed-off-by: Niv Sardi <xaiki@sgi.com>
  • Loading branch information
Christoph Hellwig authored and Niv Sardi committed Dec 1, 2008
1 parent 6c31b93 commit 6579591
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
2 changes: 1 addition & 1 deletion fs/xfs/linux-2.6/xfs_stats.c
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ xfs_read_xfsstats(

/* Loop over all stats groups */
for (i=j=len = 0; i < ARRAY_SIZE(xstats); i++) {
len += sprintf(buffer + len, xstats[i].desc);
len += sprintf(buffer + len, "%s", xstats[i].desc);
/* inner loop does each group */
while (j < xstats[i].endpoint) {
val = 0;
Expand Down
5 changes: 2 additions & 3 deletions fs/xfs/linux-2.6/xfs_super.c
Original file line number Diff line number Diff line change
Expand Up @@ -1848,10 +1848,9 @@ STATIC int __init
init_xfs_fs(void)
{
int error;
static char message[] __initdata = KERN_INFO \
XFS_VERSION_STRING " with " XFS_BUILD_OPTIONS " enabled\n";

printk(message);
printk(KERN_INFO XFS_VERSION_STRING " with "
XFS_BUILD_OPTIONS " enabled\n");

ktrace_init(64);
vn_init();
Expand Down

0 comments on commit 6579591

Please sign in to comment.