Skip to content

Commit

Permalink
NET: dmfe: don't access configuration space in D3 state
Browse files Browse the repository at this point in the history
 Accidently I reversed the order of pci_save_state and
 pci_set_power_state in .suspend()/.resume() callbacks

Signed-off-by: Maxim Levitsky <maximlevitsky@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
  • Loading branch information
Maxim Levitsky authored and Jeff Garzik committed Nov 24, 2007
1 parent 7b31f7f commit 65809b5
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/net/tulip/dmfe.c
Original file line number Diff line number Diff line change
Expand Up @@ -2118,8 +2118,8 @@ static int dmfe_suspend(struct pci_dev *pci_dev, pm_message_t state)
pci_enable_wake(pci_dev, PCI_D3cold, 1);

/* Power down device*/
pci_set_power_state(pci_dev, pci_choose_state (pci_dev,state));
pci_save_state(pci_dev);
pci_set_power_state(pci_dev, pci_choose_state (pci_dev,state));

return 0;
}
Expand All @@ -2129,8 +2129,8 @@ static int dmfe_resume(struct pci_dev *pci_dev)
struct net_device *dev = pci_get_drvdata(pci_dev);
u32 tmp;

pci_restore_state(pci_dev);
pci_set_power_state(pci_dev, PCI_D0);
pci_restore_state(pci_dev);

/* Re-initilize DM910X board */
dmfe_init_dm910x(dev);
Expand Down

0 comments on commit 65809b5

Please sign in to comment.