Skip to content

Commit

Permalink
[RAW]: Consolidate proto->hash callback
Browse files Browse the repository at this point in the history
Having the raw_hashinfo it's easy to consolidate the
raw[46]_hash functions.

Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Pavel Emelyanov authored and David S. Miller committed Jan 28, 2008
1 parent b673e4d commit 65b4c50
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 12 deletions.
2 changes: 2 additions & 0 deletions include/net/raw.h
Original file line number Diff line number Diff line change
Expand Up @@ -39,4 +39,6 @@ extern int raw_proc_init(void);
extern void raw_proc_exit(void);
#endif

void raw_hash_sk(struct sock *sk, struct raw_hashinfo *h);

#endif /* _RAW_H */
17 changes: 12 additions & 5 deletions net/ipv4/raw.c
Original file line number Diff line number Diff line change
Expand Up @@ -84,15 +84,22 @@ static struct raw_hashinfo raw_v4_hashinfo = {
.lock = __RW_LOCK_UNLOCKED(),
};

static void raw_v4_hash(struct sock *sk)
void raw_hash_sk(struct sock *sk, struct raw_hashinfo *h)
{
struct hlist_head *head = &raw_v4_hashinfo.ht[inet_sk(sk)->num &
(RAW_HTABLE_SIZE - 1)];
struct hlist_head *head;

write_lock_bh(&raw_v4_hashinfo.lock);
head = &h->ht[inet_sk(sk)->num & (RAW_HTABLE_SIZE - 1)];

write_lock_bh(&h->lock);
sk_add_node(sk, head);
sock_prot_inc_use(sk->sk_prot);
write_unlock_bh(&raw_v4_hashinfo.lock);
write_unlock_bh(&h->lock);
}
EXPORT_SYMBOL_GPL(raw_hash_sk);

static void raw_v4_hash(struct sock *sk)
{
raw_hash_sk(sk, &raw_v4_hashinfo);
}

static void raw_v4_unhash(struct sock *sk)
Expand Down
8 changes: 1 addition & 7 deletions net/ipv6/raw.c
Original file line number Diff line number Diff line change
Expand Up @@ -67,13 +67,7 @@ static struct raw_hashinfo raw_v6_hashinfo = {

static void raw_v6_hash(struct sock *sk)
{
struct hlist_head *list = &raw_v6_hashinfo.ht[inet_sk(sk)->num &
(RAW_HTABLE_SIZE - 1)];

write_lock_bh(&raw_v6_hashinfo.lock);
sk_add_node(sk, list);
sock_prot_inc_use(sk->sk_prot);
write_unlock_bh(&raw_v6_hashinfo.lock);
raw_hash_sk(sk, &raw_v6_hashinfo);
}

static void raw_v6_unhash(struct sock *sk)
Expand Down

0 comments on commit 65b4c50

Please sign in to comment.