Skip to content

Commit

Permalink
[media] dvb_usb_v2: use %*ph to dump usb xfer debugs
Browse files Browse the repository at this point in the history
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Antti Palosaari authored and Mauro Carvalho Chehab committed Aug 13, 2012
1 parent 1d16e6d commit 65d9bc9
Showing 1 changed file with 4 additions and 10 deletions.
14 changes: 4 additions & 10 deletions drivers/media/dvb/dvb-usb-v2/dvb_usb_urb.c
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@

#include "dvb_usb_common.h"

#undef DVB_USB_XFER_DEBUG
int dvb_usbv2_generic_rw(struct dvb_usb_device *d, u8 *wbuf, u16 wlen, u8 *rbuf,
u16 rlen)
{
Expand All @@ -37,10 +36,8 @@ int dvb_usbv2_generic_rw(struct dvb_usb_device *d, u8 *wbuf, u16 wlen, u8 *rbuf,
if (ret < 0)
return ret;

#ifdef DVB_USB_XFER_DEBUG
print_hex_dump(KERN_DEBUG, KBUILD_MODNAME ": >>> ", DUMP_PREFIX_NONE,
32, 1, wbuf, wlen, 0);
#endif
dev_dbg(&d->udev->dev, "%s: >>> %*ph\n", __func__, wlen, wbuf);

ret = usb_bulk_msg(d->udev, usb_sndbulkpipe(d->udev,
d->props->generic_bulk_ctrl_endpoint), wbuf, wlen,
&actual_length, 2000);
Expand All @@ -64,11 +61,8 @@ int dvb_usbv2_generic_rw(struct dvb_usb_device *d, u8 *wbuf, u16 wlen, u8 *rbuf,
dev_err(&d->udev->dev, "%s: 2nd usb_bulk_msg() " \
"failed=%d\n", KBUILD_MODNAME, ret);

#ifdef DVB_USB_XFER_DEBUG
print_hex_dump(KERN_DEBUG, KBUILD_MODNAME ": <<< ",
DUMP_PREFIX_NONE, 32, 1, rbuf, actual_length,
0);
#endif
dev_dbg(&d->udev->dev, "%s: <<< %*ph\n", __func__,
actual_length, rbuf);
}

mutex_unlock(&d->usb_mutex);
Expand Down

0 comments on commit 65d9bc9

Please sign in to comment.