Skip to content

Commit

Permalink
perf tools: Rename some variables for better understanding
Browse files Browse the repository at this point in the history
Trivial patch to improve understanding of code.

Varible attr is usually used for struct perf_event_attr. Using it in a
different context is irritating. Thus, renaming it.

Signed-off-by: Robert Richter <robert.richter@amd.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1345144224-27280-4-git-send-email-robert.richter@amd.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
  • Loading branch information
Robert Richter authored and Arnaldo Carvalho de Melo committed Aug 17, 2012
1 parent ca1b145 commit 6606f87
Showing 1 changed file with 21 additions and 21 deletions.
42 changes: 21 additions & 21 deletions tools/perf/util/header.c
Original file line number Diff line number Diff line change
Expand Up @@ -608,11 +608,11 @@ static int write_nrcpus(int fd, struct perf_header *h __used,
static int write_event_desc(int fd, struct perf_header *h __used,
struct perf_evlist *evlist)
{
struct perf_evsel *attr;
struct perf_evsel *evsel;
u32 nre = 0, nri, sz;
int ret;

list_for_each_entry(attr, &evlist->entries, node)
list_for_each_entry(evsel, &evlist->entries, node)
nre++;

/*
Expand All @@ -625,14 +625,14 @@ static int write_event_desc(int fd, struct perf_header *h __used,
/*
* size of perf_event_attr struct
*/
sz = (u32)sizeof(attr->attr);
sz = (u32)sizeof(evsel->attr);
ret = do_write(fd, &sz, sizeof(sz));
if (ret < 0)
return ret;

list_for_each_entry(attr, &evlist->entries, node) {
list_for_each_entry(evsel, &evlist->entries, node) {

ret = do_write(fd, &attr->attr, sz);
ret = do_write(fd, &evsel->attr, sz);
if (ret < 0)
return ret;
/*
Expand All @@ -642,21 +642,21 @@ static int write_event_desc(int fd, struct perf_header *h __used,
* copy into an nri to be independent of the
* type of ids,
*/
nri = attr->ids;
nri = evsel->ids;
ret = do_write(fd, &nri, sizeof(nri));
if (ret < 0)
return ret;

/*
* write event string as passed on cmdline
*/
ret = do_write_string(fd, perf_evsel__name(attr));
ret = do_write_string(fd, perf_evsel__name(evsel));
if (ret < 0)
return ret;
/*
* write unique ids for this event
*/
ret = do_write(fd, attr->id, attr->ids * sizeof(u64));
ret = do_write(fd, evsel->id, evsel->ids * sizeof(u64));
if (ret < 0)
return ret;
}
Expand Down Expand Up @@ -1683,17 +1683,17 @@ int perf_session__write_header(struct perf_session *session,
struct perf_file_header f_header;
struct perf_file_attr f_attr;
struct perf_header *header = &session->header;
struct perf_evsel *attr, *pair = NULL;
struct perf_evsel *evsel, *pair = NULL;
int err;

lseek(fd, sizeof(f_header), SEEK_SET);

if (session->evlist != evlist)
pair = perf_evlist__first(session->evlist);

list_for_each_entry(attr, &evlist->entries, node) {
attr->id_offset = lseek(fd, 0, SEEK_CUR);
err = do_write(fd, attr->id, attr->ids * sizeof(u64));
list_for_each_entry(evsel, &evlist->entries, node) {
evsel->id_offset = lseek(fd, 0, SEEK_CUR);
err = do_write(fd, evsel->id, evsel->ids * sizeof(u64));
if (err < 0) {
out_err_write:
pr_debug("failed to write perf header\n");
Expand All @@ -1703,19 +1703,19 @@ int perf_session__write_header(struct perf_session *session,
err = do_write(fd, pair->id, pair->ids * sizeof(u64));
if (err < 0)
goto out_err_write;
attr->ids += pair->ids;
evsel->ids += pair->ids;
pair = perf_evsel__next(pair);
}
}

header->attr_offset = lseek(fd, 0, SEEK_CUR);

list_for_each_entry(attr, &evlist->entries, node) {
list_for_each_entry(evsel, &evlist->entries, node) {
f_attr = (struct perf_file_attr){
.attr = attr->attr,
.attr = evsel->attr,
.ids = {
.offset = attr->id_offset,
.size = attr->ids * sizeof(u64),
.offset = evsel->id_offset,
.size = evsel->ids * sizeof(u64),
}
};
err = do_write(fd, &f_attr, sizeof(f_attr));
Expand Down Expand Up @@ -2277,12 +2277,12 @@ int perf_event__synthesize_attrs(struct perf_tool *tool,
struct perf_session *session,
perf_event__handler_t process)
{
struct perf_evsel *attr;
struct perf_evsel *evsel;
int err = 0;

list_for_each_entry(attr, &session->evlist->entries, node) {
err = perf_event__synthesize_attr(tool, &attr->attr, attr->ids,
attr->id, process);
list_for_each_entry(evsel, &session->evlist->entries, node) {
err = perf_event__synthesize_attr(tool, &evsel->attr, evsel->ids,
evsel->id, process);
if (err) {
pr_debug("failed to create perf header attribute\n");
return err;
Expand Down

0 comments on commit 6606f87

Please sign in to comment.