Skip to content

Commit

Permalink
[media] s5p-fimc: Avoid possible NULL pointer dereference in set_fmt op
Browse files Browse the repository at this point in the history
This fixes following issue found with a static analysis tool:
Pointer 'ffmt' returned from call to function 'fimc_capture_try_format'
at line 1522 may be NULL and may be dereferenced at line 1535.
Although it shouldn't happen in practice, add the NULL pointer check
to be on the safe side.

Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Sylwester Nawrocki authored and Mauro Carvalho Chehab committed Jan 6, 2013
1 parent ff4e3fe commit 6612545
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions drivers/media/platform/s5p-fimc/fimc-capture.c
Original file line number Diff line number Diff line change
Expand Up @@ -1561,6 +1561,10 @@ static int fimc_subdev_set_fmt(struct v4l2_subdev *sd,
*mf = fmt->format;
return 0;
}
/* There must be a bug in the driver if this happens */
if (WARN_ON(ffmt == NULL))
return -EINVAL;

/* Update RGB Alpha control state and value range */
fimc_alpha_ctrl_update(ctx);

Expand Down

0 comments on commit 6612545

Please sign in to comment.