Skip to content

Commit

Permalink
V4L/DVB (6192): Ensure start_dma() is capable of starting dma on port…
Browse files Browse the repository at this point in the history
… VIDB

start_dma() would fail to start dma if a device used VIDB (portb).

Signed-off-by: Steven Toth <stoth@hauppauge.com>
Reviewed-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
  • Loading branch information
Steven Toth authored and Mauro Carvalho Chehab committed Oct 10, 2007
1 parent bfde287 commit 661c7e4
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 7 deletions.
9 changes: 6 additions & 3 deletions drivers/media/video/cx23885/cx23885-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -1015,9 +1015,12 @@ static int cx23885_start_dma(struct cx23885_tsport *port,
/* write TS length to chip */
cx_write(port->reg_lngth, buf->vb.width);

if (!(cx23885_boards[dev->board].portc & CX23885_MPEG_DVB)) {
printk( "%s() Failed. Unsupported value in .portc (0x%08x)\n",
__FUNCTION__, cx23885_boards[dev->board].portc );
if ( (!(cx23885_boards[dev->board].portb & CX23885_MPEG_DVB)) &&
(!(cx23885_boards[dev->board].portc & CX23885_MPEG_DVB)) ) {
printk( "%s() Failed. Unsupported value in .portb/c (0x%08x)/(0x%08x)\n",
__FUNCTION__,
cx23885_boards[dev->board].portb,
cx23885_boards[dev->board].portc );
return -EINVAL;
}

Expand Down
10 changes: 6 additions & 4 deletions drivers/media/video/cx23885/cx23885.h
Original file line number Diff line number Diff line change
Expand Up @@ -86,12 +86,14 @@ struct cx23885_input {
u32 gpio0, gpio1, gpio2, gpio3;
};

typedef enum {
CX23885_MPEG_UNDEFINED = 0,
CX23885_MPEG_DVB
} port_t;

struct cx23885_board {
char *name;
enum {
CX23885_MPEG_UNDEFINED = 0,
CX23885_MPEG_DVB
} portc;
port_t portb, portc;
struct cx23885_input input[MAX_CX23885_INPUT];
};

Expand Down

0 comments on commit 661c7e4

Please sign in to comment.