Skip to content

Commit

Permalink
drm/i915: check i915_get_reset_stats_ioctl args
Browse files Browse the repository at this point in the history
Insist that flags and pad fields are zero, so that
we can safely extend the interface in future.

Testcase: igt/gem_reset_stats/params

Suggested-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
  • Loading branch information
Mika Kuoppala authored and Daniel Vetter committed Nov 13, 2013
1 parent b53c8c3 commit 661df04
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions drivers/gpu/drm/i915/intel_uncore.c
Original file line number Diff line number Diff line change
Expand Up @@ -641,6 +641,9 @@ int i915_get_reset_stats_ioctl(struct drm_device *dev,
struct i915_ctx_hang_stats *hs;
int ret;

if (args->flags || args->pad)
return -EINVAL;

if (args->ctx_id == DEFAULT_CONTEXT_ID && !capable(CAP_SYS_ADMIN))
return -EPERM;

Expand Down

0 comments on commit 661df04

Please sign in to comment.