Skip to content

Commit

Permalink
ext3: fix return values on parse_options() failure
Browse files Browse the repository at this point in the history
parse_options() in ext3 should return 0 when parse the mount options fails.

Signed-off-by: Zhao Hongjiang <zhaohongjiang@huawei.com>
Reviewed-by: Lukas Czerner <lczerner@redhat.com>
Signed-off-by: Jan Kara <jack@suse.cz>
  • Loading branch information
Zhao Hongjiang authored and Jan Kara committed Oct 9, 2012
1 parent ae2cf42 commit 66415f6
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions fs/ext3/super.c
Original file line number Diff line number Diff line change
Expand Up @@ -1001,7 +1001,7 @@ static int parse_options (char *options, struct super_block *sb,
uid = make_kuid(current_user_ns(), option);
if (!uid_valid(uid)) {
ext3_msg(sb, KERN_ERR, "Invalid uid value %d", option);
return -1;
return 0;

}
sbi->s_resuid = uid;
Expand All @@ -1012,7 +1012,7 @@ static int parse_options (char *options, struct super_block *sb,
gid = make_kgid(current_user_ns(), option);
if (!gid_valid(gid)) {
ext3_msg(sb, KERN_ERR, "Invalid gid value %d", option);
return -1;
return 0;
}
sbi->s_resgid = gid;
break;
Expand Down

0 comments on commit 66415f6

Please sign in to comment.