Skip to content

Commit

Permalink
TTY: 68328serial, use tty from tty_port
Browse files Browse the repository at this point in the history
And refcount that properly.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-m68k@lists.linux-m68k.org
Acked-by: Greg Ungerer <gerg@uclinux.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Jiri Slaby authored and Greg Kroah-Hartman committed Apr 9, 2012
1 parent 467712c commit 665569d
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions drivers/tty/serial/68328serial.c
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,6 @@ struct m68k_serial {
int port;
int irq;
int type; /* UART type */
struct tty_struct *tty;
int custom_divisor;
int x_char; /* xon/xoff character */
int line;
Expand Down Expand Up @@ -356,7 +355,7 @@ static void transmit_chars(struct m68k_serial *info, struct tty_struct *tty)
irqreturn_t rs_interrupt(int irq, void *dev_id)
{
struct m68k_serial *info = dev_id;
struct tty_struct *tty = info->tty;
struct tty_struct *tty = tty_port_tty_get(&info->tport);
m68328_uart *uart;
unsigned short rx;
unsigned short tx;
Expand All @@ -374,6 +373,8 @@ irqreturn_t rs_interrupt(int irq, void *dev_id)
#else
receive_chars(info, tty, rx);
#endif
tty_kref_put(tty);

return IRQ_HANDLED;
}

Expand Down Expand Up @@ -1062,7 +1063,7 @@ static void rs_close(struct tty_struct *tty, struct file * filp)

tty_ldisc_flush(tty);
tty->closing = 0;
info->tty = NULL;
tty_port_tty_set(&info->tport, NULL);
#warning "This is not and has never been valid so fix it"
#if 0
if (tty->ldisc.num != ldiscs[N_TTY].num) {
Expand Down Expand Up @@ -1098,7 +1099,7 @@ void rs_hangup(struct tty_struct *tty)
shutdown(info, tty);
info->tport.count = 0;
info->tport.flags &= ~ASYNC_NORMAL_ACTIVE;
info->tty = NULL;
tty_port_tty_set(&info->tport, NULL);
wake_up_interruptible(&info->tport.open_wait);
}

Expand Down Expand Up @@ -1210,7 +1211,7 @@ int rs_open(struct tty_struct *tty, struct file * filp)

info->tport.count++;
tty->driver_data = info;
info->tty = tty;
tty_port_tty_set(&info->tport, tty);

/*
* Start up serial port
Expand Down Expand Up @@ -1289,7 +1290,6 @@ rs68328_init(void)
tty_port_init(&info->tport);
info->magic = SERIAL_MAGIC;
info->port = (int) &uart_addr[i];
info->tty = NULL;
info->irq = uart_irqs[i];
info->custom_divisor = 16;
info->x_char = 0;
Expand Down

0 comments on commit 665569d

Please sign in to comment.