Skip to content

Commit

Permalink
dma: tegra: do not set transfer desc flag to DMA_CTRL_ACK in cyclic mode
Browse files Browse the repository at this point in the history
The sound dmaengine pcm driver uses the dma in cyclic mode and
it does not ack the transfer descriptor  after transfer stops.
This may lead to hold that desc in chip's dma driver and does
not allow to reuse/free that descriptors. Hence not enabling
flag DMA_CTRL_ACK when dma runs in cyclic mode.

Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
Acked-by: Stephen Warren <swarren@wwwdotorg.org>
Signed-off-by: Vinod Koul <vinod.koul@linux.intel.com>
  • Loading branch information
Laxman Dewangan authored and Vinod Koul committed Jun 27, 2012
1 parent 56482ec commit 6660f7a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/dma/tegra20-apb-dma.c
Original file line number Diff line number Diff line change
Expand Up @@ -1093,7 +1093,7 @@ struct dma_async_tx_descriptor *tegra_dma_prep_dma_cyclic(
mem += len;
}
sg_req->last_sg = true;
dma_desc->txd.flags = DMA_CTRL_ACK;
dma_desc->txd.flags = 0;

/*
* Make sure that mode should not be conflicting with currently
Expand Down

0 comments on commit 6660f7a

Please sign in to comment.