Skip to content

Commit

Permalink
ARM: SMP implementations are not supposed to return from smp_ops.cpu_…
Browse files Browse the repository at this point in the history
…die()

Although we allow recovery in this case, this is not supposed to be
the normal path for hotplugging a CPU back in.  This path only exists
to serve those rare platforms where it's not possible to power down
the CPU or reset the CPU.  This patch causes the kernel to print a
message when a platform uses this path.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
  • Loading branch information
Russell King committed Jan 21, 2014
1 parent 571b143 commit 668bc38
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions arch/arm/kernel/smp.c
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,9 @@ void __ref cpu_die(void)
if (smp_ops.cpu_die)
smp_ops.cpu_die(cpu);

pr_warn("CPU%u: smp_ops.cpu_die() returned, trying to resuscitate\n",
cpu);

/*
* Do not return to the idle loop - jump back to the secondary
* cpu initialisation. There's some initialisation which needs
Expand Down

0 comments on commit 668bc38

Please sign in to comment.