Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 338421
b: refs/heads/master
c: 9a8e62b
h: refs/heads/master
i:
  338419: ff7b515
v: v3
  • Loading branch information
Jiri Slaby authored and Greg Kroah-Hartman committed Nov 16, 2012
1 parent 4867bfd commit 66a199f
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 7 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: e70c67713cdabf55e05db7f1c4fc38085da333a5
refs/heads/master: 9a8e62bc68832dc55a5e6868f812b65567fe66b5
11 changes: 5 additions & 6 deletions trunk/drivers/tty/n_gsm.c
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,6 @@ struct gsm_dlci {
#define DLCI_OPENING 1 /* Sending SABM not seen UA */
#define DLCI_OPEN 2 /* SABM/UA complete */
#define DLCI_CLOSING 3 /* Sending DISC not seen UA/DM */
struct kref ref; /* freed from port or mux close */
struct mutex mutex;

/* Link layer */
Expand Down Expand Up @@ -1635,7 +1634,6 @@ static struct gsm_dlci *gsm_dlci_alloc(struct gsm_mux *gsm, int addr)
if (dlci == NULL)
return NULL;
spin_lock_init(&dlci->lock);
kref_init(&dlci->ref);
mutex_init(&dlci->mutex);
dlci->fifo = &dlci->_fifo;
if (kfifo_alloc(&dlci->_fifo, 4096, GFP_KERNEL) < 0) {
Expand Down Expand Up @@ -1669,9 +1667,9 @@ static struct gsm_dlci *gsm_dlci_alloc(struct gsm_mux *gsm, int addr)
*
* Can sleep.
*/
static void gsm_dlci_free(struct kref *ref)
static void gsm_dlci_free(struct tty_port *port)
{
struct gsm_dlci *dlci = container_of(ref, struct gsm_dlci, ref);
struct gsm_dlci *dlci = container_of(port, struct gsm_dlci, port);

del_timer_sync(&dlci->t1);
dlci->gsm->dlci[dlci->addr] = NULL;
Expand All @@ -1683,12 +1681,12 @@ static void gsm_dlci_free(struct kref *ref)

static inline void dlci_get(struct gsm_dlci *dlci)
{
kref_get(&dlci->ref);
tty_port_get(&dlci->port);
}

static inline void dlci_put(struct gsm_dlci *dlci)
{
kref_put(&dlci->ref, gsm_dlci_free);
tty_port_put(&dlci->port);
}

/**
Expand Down Expand Up @@ -2874,6 +2872,7 @@ static void gsm_dtr_rts(struct tty_port *port, int onoff)
static const struct tty_port_operations gsm_port_ops = {
.carrier_raised = gsm_carrier_raised,
.dtr_rts = gsm_dtr_rts,
.destruct = gsm_dlci_free,
};

static int gsmtty_install(struct tty_driver *driver, struct tty_struct *tty)
Expand Down

0 comments on commit 66a199f

Please sign in to comment.