Skip to content

Commit

Permalink
[ALSA] es1968 - fix coding style in the last patch
Browse files Browse the repository at this point in the history
WARNING: braces {} are not necessary for single statement blocks
#40: FILE: sound/pci/es1968.c:1831:
+       if (diff > 1) {
+               __maestro_write(chip, IDR0_DATA_PORT, cp1);
+       }

total: 0 errors, 1 warnings, 35 lines checked

./patches/es1968-fix-jitter-on-some-maestro-cards.patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Andreas Mueller <andreas@stapelspeicher.org>
Tested-by: Rene Herman <rene.herman@keyaccess.nl>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
  • Loading branch information
Andrew Morton authored and Takashi Iwai committed Apr 24, 2008
1 parent f24bfa5 commit 66c9aa6
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions sound/pci/es1968.c
Original file line number Diff line number Diff line change
Expand Up @@ -1840,9 +1840,8 @@ static void snd_es1968_suppress_jitter(struct es1968 *chip, struct esschan *es)
cp2 = __apu_get_register(chip, 1, 5);
diff = (cp1 > cp2 ? cp1 - cp2 : cp2 - cp1);

if (diff > 1) {
if (diff > 1)
__maestro_write(chip, IDR0_DATA_PORT, cp1);
}
}

/*
Expand Down

0 comments on commit 66c9aa6

Please sign in to comment.