Skip to content

Commit

Permalink
[PATCH] ipmi: strstrip conversion
Browse files Browse the repository at this point in the history
Switch an open-coded strstrip() to use the new API.

Acked-by: Corey Minyard <minyard@acm.org>
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Pekka Enberg authored and Linus Torvalds committed Jun 23, 2006
1 parent 481fad4 commit 66f969d
Showing 1 changed file with 9 additions and 16 deletions.
25 changes: 9 additions & 16 deletions drivers/char/ipmi/ipmi_watchdog.c
Original file line number Diff line number Diff line change
Expand Up @@ -212,24 +212,16 @@ static int set_param_str(const char *val, struct kernel_param *kp)
{
action_fn fn = (action_fn) kp->arg;
int rv = 0;
const char *end;
char valcp[16];
int len;

/* Truncate leading and trailing spaces. */
while (isspace(*val))
val++;
end = val + strlen(val) - 1;
while ((end >= val) && isspace(*end))
end--;
len = end - val + 1;
if (len > sizeof(valcp) - 1)
return -EINVAL;
memcpy(valcp, val, len);
valcp[len] = '\0';
char *dup, *s;

dup = kstrdup(val, GFP_KERNEL);
if (!dup)
return -ENOMEM;

s = strstrip(dup);

down_read(&register_sem);
rv = fn(valcp, NULL);
rv = fn(s, NULL);
if (rv)
goto out_unlock;

Expand All @@ -239,6 +231,7 @@ static int set_param_str(const char *val, struct kernel_param *kp)

out_unlock:
up_read(&register_sem);
kfree(dup);
return rv;
}

Expand Down

0 comments on commit 66f969d

Please sign in to comment.