Skip to content

Commit

Permalink
perf: Fix strncpy() use, use strlcpy() instead of strncpy()
Browse files Browse the repository at this point in the history
For NUL terminated string we always need to set '\0' at the end.

Signed-off-by: Chen Gang <gang.chen@asianux.com>
Cc: rostedt@goodmis.org
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Link: http://lkml.kernel.org/r/51624254.30301@asianux.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
  • Loading branch information
Chen Gang authored and Ingo Molnar committed Apr 8, 2013
1 parent c97847d commit 67012ab
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions kernel/trace/trace.c
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ static char *default_bootup_tracer;

static int __init set_cmdline_ftrace(char *str)
{
strncpy(bootup_tracer_buf, str, MAX_TRACER_SIZE);
strlcpy(bootup_tracer_buf, str, MAX_TRACER_SIZE);
default_bootup_tracer = bootup_tracer_buf;
/* We are using ftrace early, expand it */
ring_buffer_expanded = 1;
Expand Down Expand Up @@ -162,7 +162,7 @@ static char *trace_boot_options __initdata;

static int __init set_trace_boot_options(char *str)
{
strncpy(trace_boot_options_buf, str, MAX_TRACER_SIZE);
strlcpy(trace_boot_options_buf, str, MAX_TRACER_SIZE);
trace_boot_options = trace_boot_options_buf;
return 0;
}
Expand Down

0 comments on commit 67012ab

Please sign in to comment.