Skip to content

Commit

Permalink
HID: wiimote: Register input device in wiimote hid driver
Browse files Browse the repository at this point in the history
Register input device so the wiimote can report input events on
it. We do not use HIDINPUT because the wiimote does not provide any
descriptor table which might be used by HIDINPUT. So we avoid
having HIDINPUT parse the wiimote descriptor and create unrelated
or unknown event flags. Instead we register our own input device
that we have full control of.

Signed-off-by: David Herrmann <dh.herrmann@googlemail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
  • Loading branch information
David Herrmann authored and Jiri Kosina committed Jul 11, 2011
1 parent e894d0e commit 672bc4e
Showing 1 changed file with 34 additions and 0 deletions.
34 changes: 34 additions & 0 deletions drivers/hid/hid-wiimote.c
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,9 @@
* any later version.
*/

#include <linux/device.h>
#include <linux/hid.h>
#include <linux/input.h>
#include <linux/module.h>
#include "hid-ids.h"

Expand All @@ -19,8 +21,15 @@

struct wiimote_data {
struct hid_device *hdev;
struct input_dev *input;
};

static int wiimote_input_event(struct input_dev *dev, unsigned int type,
unsigned int code, int value)
{
return 0;
}

static int wiimote_hid_event(struct hid_device *hdev, struct hid_report *report,
u8 *raw_data, int size)
{
Expand All @@ -38,9 +47,24 @@ static struct wiimote_data *wiimote_create(struct hid_device *hdev)
if (!wdata)
return NULL;

wdata->input = input_allocate_device();
if (!wdata->input) {
kfree(wdata);
return NULL;
}

wdata->hdev = hdev;
hid_set_drvdata(hdev, wdata);

input_set_drvdata(wdata->input, wdata);
wdata->input->event = wiimote_input_event;
wdata->input->dev.parent = &wdata->hdev->dev;
wdata->input->id.bustype = wdata->hdev->bus;
wdata->input->id.vendor = wdata->hdev->vendor;
wdata->input->id.product = wdata->hdev->product;
wdata->input->id.version = wdata->hdev->version;
wdata->input->name = WIIMOTE_NAME;

return wdata;
}

Expand Down Expand Up @@ -73,10 +97,19 @@ static int wiimote_hid_probe(struct hid_device *hdev,
goto err;
}

ret = input_register_device(wdata->input);
if (ret) {
hid_err(hdev, "Cannot register input device\n");
goto err_stop;
}

hid_info(hdev, "New device registered\n");
return 0;

err_stop:
hid_hw_stop(hdev);
err:
input_free_device(wdata->input);
wiimote_destroy(wdata);
return ret;
}
Expand All @@ -87,6 +120,7 @@ static void wiimote_hid_remove(struct hid_device *hdev)

hid_info(hdev, "Device removed\n");
hid_hw_stop(hdev);
input_unregister_device(wdata->input);
wiimote_destroy(wdata);
}

Expand Down

0 comments on commit 672bc4e

Please sign in to comment.