Skip to content

Commit

Permalink
[PATCH] mm: less atomic ops
Browse files Browse the repository at this point in the history
In the page release paths, we can be sure that nobody will mess with our
page->flags because the refcount has dropped to 0.  So no need for atomic
operations here.

Signed-off-by: Nick Piggin <npiggin@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Nick Piggin authored and Linus Torvalds committed Mar 22, 2006
1 parent 4c84cac commit 6745391
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion include/linux/mm_inline.h
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ del_page_from_lru(struct zone *zone, struct page *page)
{
list_del(&page->lru);
if (PageActive(page)) {
ClearPageActive(page);
__ClearPageActive(page);
zone->nr_active--;
} else {
zone->nr_inactive--;
Expand Down
2 changes: 2 additions & 0 deletions include/linux/page-flags.h
Original file line number Diff line number Diff line change
Expand Up @@ -242,10 +242,12 @@ extern void __mod_page_state_offset(unsigned long offset, unsigned long delta);
#define PageLRU(page) test_bit(PG_lru, &(page)->flags)
#define SetPageLRU(page) set_bit(PG_lru, &(page)->flags)
#define ClearPageLRU(page) clear_bit(PG_lru, &(page)->flags)
#define __ClearPageLRU(page) __clear_bit(PG_lru, &(page)->flags)

#define PageActive(page) test_bit(PG_active, &(page)->flags)
#define SetPageActive(page) set_bit(PG_active, &(page)->flags)
#define ClearPageActive(page) clear_bit(PG_active, &(page)->flags)
#define __ClearPageActive(page) __clear_bit(PG_active, &(page)->flags)

#define PageSlab(page) test_bit(PG_slab, &(page)->flags)
#define SetPageSlab(page) set_bit(PG_slab, &(page)->flags)
Expand Down
4 changes: 2 additions & 2 deletions mm/swap.c
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ void fastcall __page_cache_release(struct page *page)

spin_lock_irqsave(&zone->lru_lock, flags);
BUG_ON(!PageLRU(page));
ClearPageLRU(page);
__ClearPageLRU(page);
del_page_from_lru(zone, page);
spin_unlock_irqrestore(&zone->lru_lock, flags);
}
Expand Down Expand Up @@ -266,7 +266,7 @@ void release_pages(struct page **pages, int nr, int cold)
spin_lock_irq(&zone->lru_lock);
}
BUG_ON(!PageLRU(page));
ClearPageLRU(page);
__ClearPageLRU(page);
del_page_from_lru(zone, page);
}

Expand Down

0 comments on commit 6745391

Please sign in to comment.