Skip to content

Commit

Permalink
[PATCH] dvb: core: fix race condition in FE_READ_STATUS ioctl
Browse files Browse the repository at this point in the history
Fix a race condition where an application which issued a FE_READ_STATUS ioctl
directly after FE_SET_FRONTEND would see an old status, i.e.  FE_READ_STATUS
would be executed before the frontend thread has even seen the tungin request
from FE_SET_FRONTEND.

Signed-off-by: Peter Beutner <p.beutner@gmx.net>
Signed-off-by: Johannes Stezenbach <js@linuxtv.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Peter Beutner authored and Linus Torvalds committed Jul 8, 2005
1 parent 25a26ec commit 6757ccc
Showing 1 changed file with 13 additions and 3 deletions.
16 changes: 13 additions & 3 deletions drivers/media/dvb/dvb-core/dvb_frontend.c
Original file line number Diff line number Diff line change
Expand Up @@ -626,11 +626,21 @@ static int dvb_frontend_ioctl(struct inode *inode, struct file *file,
break;
}

case FE_READ_STATUS:
case FE_READ_STATUS: {
fe_status_t* status = parg;

/* if retune was requested but hasn't occured yet, prevent
* that user get signal state from previous tuning */
if(fepriv->state == FESTATE_RETUNE) {
err=0;
*status = 0;
break;
}

if (fe->ops->read_status)
err = fe->ops->read_status(fe, (fe_status_t*) parg);
err = fe->ops->read_status(fe, status);
break;

}
case FE_READ_BER:
if (fe->ops->read_ber)
err = fe->ops->read_ber(fe, (__u32*) parg);
Expand Down

0 comments on commit 6757ccc

Please sign in to comment.