Skip to content

Commit

Permalink
ARM: sirf: fix prima2 interrupt lookup
Browse files Browse the repository at this point in the history
We must not read the interrupts property manually but instead
use irq_of_parse_and_map() to guarantee that we get the correct
interrupt number once we stop using the legacy IRQ domain.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Tested-by: Barry Song <Baohua.Song@csr.com>
  • Loading branch information
Arnd Bergmann committed Mar 25, 2013
1 parent b426476 commit 67d7134
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions arch/arm/mach-prima2/timer-prima2.c
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
#include <linux/err.h>
#include <linux/slab.h>
#include <linux/of.h>
#include <linux/of_irq.h>
#include <linux/of_address.h>
#include <mach/map.h>
#include <asm/sched_clock.h>
Expand Down Expand Up @@ -223,7 +224,6 @@ static struct of_device_id timer_ids[] = {
static void __init sirfsoc_of_timer_map(void)
{
struct device_node *np;
const unsigned int *intspec;

np = of_find_matching_node(NULL, timer_ids);
if (!np)
Expand All @@ -233,9 +233,7 @@ static void __init sirfsoc_of_timer_map(void)
panic("unable to map timer cpu registers\n");

/* Get the interrupts property */
intspec = of_get_property(np, "interrupts", NULL);
BUG_ON(!intspec);
sirfsoc_timer_irq.irq = be32_to_cpup(intspec);
sirfsoc_timer_irq.irq = irq_of_parse_and_map(np, 0);

of_node_put(np);
}

0 comments on commit 67d7134

Please sign in to comment.