Skip to content

Commit

Permalink
reiserfs: Remove i_mutex use from reiserfs_quota_write()
Browse files Browse the repository at this point in the history
We don't need i_mutex in reiserfs_quota_write() because writes to quota file
are serialized by dqio_mutex anyway. Changes to quota files outside of quota
code are forbidded and enforced by NOATIME and IMMUTABLE bits.

Signed-off-by: Jan Kara <jack@suse.cz>
  • Loading branch information
Jan Kara committed May 15, 2012
1 parent 0b7f7ce commit 67f1648
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions fs/reiserfs/super.c
Original file line number Diff line number Diff line change
Expand Up @@ -2270,7 +2270,6 @@ static ssize_t reiserfs_quota_write(struct super_block *sb, int type,
(unsigned long long)off, (unsigned long long)len);
return -EIO;
}
mutex_lock_nested(&inode->i_mutex, I_MUTEX_QUOTA);
while (towrite > 0) {
tocopy = sb->s_blocksize - offset < towrite ?
sb->s_blocksize - offset : towrite;
Expand Down Expand Up @@ -2302,16 +2301,13 @@ static ssize_t reiserfs_quota_write(struct super_block *sb, int type,
blk++;
}
out:
if (len == towrite) {
mutex_unlock(&inode->i_mutex);
if (len == towrite)
return err;
}
if (inode->i_size < off + len - towrite)
i_size_write(inode, off + len - towrite);
inode->i_version++;
inode->i_mtime = inode->i_ctime = CURRENT_TIME;
mark_inode_dirty(inode);
mutex_unlock(&inode->i_mutex);
return len - towrite;
}

Expand Down

0 comments on commit 67f1648

Please sign in to comment.