Skip to content

Commit

Permalink
PCI: pciehp: ignore undefined bit in link status register
Browse files Browse the repository at this point in the history
Bit 10 in Link Status register used to be defined as Training Error in
the PCI Express 1.0a specification. But it was removed by Training Error
ECN and is no longer defined. So pciehp must ignore the value read from
it.

Signed-off-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
  • Loading branch information
Kenji Kaneshige authored and Jesse Barnes committed Jan 7, 2009
1 parent 46bbdfa commit 67f6533
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/pci/hotplug/pciehp_hpc.c
Original file line number Diff line number Diff line change
Expand Up @@ -419,8 +419,7 @@ static int hpc_check_lnk_status(struct controller *ctrl)
}

ctrl_dbg(ctrl, "%s: lnk_status = %x\n", __func__, lnk_status);
if ( (lnk_status & LNK_TRN) || (lnk_status & LNK_TRN_ERR) ||
!(lnk_status & NEG_LINK_WD)) {
if ((lnk_status & LNK_TRN) || !(lnk_status & NEG_LINK_WD)) {
ctrl_err(ctrl, "Link Training Error occurs \n");
retval = -1;
return retval;
Expand Down

0 comments on commit 67f6533

Please sign in to comment.