Skip to content

Commit

Permalink
drm/radeon: fix VCE fence command
Browse files Browse the repository at this point in the history
Due to a type mismatch that causes an implicit type conversion, the
upper 32 bits of the GPU address have been zeroed out when adding to the
command buffer.

Picked up by Coverity - CID 1198624.

Signed-off-by: Christoph Jaeger <christophjaeger@linux.com>
  • Loading branch information
Christoph Jaeger authored and Christian König committed Apr 17, 2014
1 parent 7e1858f commit 681941c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/gpu/drm/radeon/radeon_vce.c
Original file line number Diff line number Diff line change
Expand Up @@ -613,7 +613,7 @@ void radeon_vce_fence_emit(struct radeon_device *rdev,
struct radeon_fence *fence)
{
struct radeon_ring *ring = &rdev->ring[fence->ring];
uint32_t addr = rdev->fence_drv[fence->ring].gpu_addr;
uint64_t addr = rdev->fence_drv[fence->ring].gpu_addr;

radeon_ring_write(ring, VCE_CMD_FENCE);
radeon_ring_write(ring, addr);
Expand Down

0 comments on commit 681941c

Please sign in to comment.