Skip to content

Commit

Permalink
[PATCH] drivers/char/nvram.c: possible cleanups
Browse files Browse the repository at this point in the history
This patch contains the following possible cleanups:
- make the needlessly global function __nvram_set_checksum static
- #if 0 the unused global function nvram_set_checksum
- remove the EXPORT_SYMBOL's for both functions

Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Adrian Bunk authored and Linus Torvalds committed Jun 25, 2005
1 parent 3b01b47 commit 681ea4b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
6 changes: 3 additions & 3 deletions drivers/char/nvram.c
Original file line number Diff line number Diff line change
Expand Up @@ -211,12 +211,13 @@ nvram_check_checksum(void)
return rv;
}

void
static void
__nvram_set_checksum(void)
{
mach_set_checksum();
}

#if 0
void
nvram_set_checksum(void)
{
Expand All @@ -226,6 +227,7 @@ nvram_set_checksum(void)
__nvram_set_checksum();
spin_unlock_irqrestore(&rtc_lock, flags);
}
#endif /* 0 */

/*
* The are the file operation function for user access to /dev/nvram
Expand Down Expand Up @@ -921,6 +923,4 @@ EXPORT_SYMBOL(__nvram_write_byte);
EXPORT_SYMBOL(nvram_write_byte);
EXPORT_SYMBOL(__nvram_check_checksum);
EXPORT_SYMBOL(nvram_check_checksum);
EXPORT_SYMBOL(__nvram_set_checksum);
EXPORT_SYMBOL(nvram_set_checksum);
MODULE_ALIAS_MISCDEV(NVRAM_MINOR);
2 changes: 0 additions & 2 deletions include/linux/nvram.h
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ extern void __nvram_write_byte(unsigned char c, int i);
extern void nvram_write_byte(unsigned char c, int i);
extern int __nvram_check_checksum(void);
extern int nvram_check_checksum(void);
extern void __nvram_set_checksum(void);
extern void nvram_set_checksum(void);
#endif

#endif /* _LINUX_NVRAM_H */

0 comments on commit 681ea4b

Please sign in to comment.