Skip to content

Commit

Permalink
KVM: Portability: Move kvm{pic,ioapic} accesors to x86 specific code
Browse files Browse the repository at this point in the history
Signed-off-by: Zhang Xiantao <xiantao.zhang@intel.com>
Signed-off-by: Avi Kivity <avi@qumranet.com>
  • Loading branch information
Zhang Xiantao authored and Avi Kivity committed Jan 30, 2008
1 parent 2bacc55 commit 682c59a
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 18 deletions.
18 changes: 16 additions & 2 deletions drivers/kvm/irq.h
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
#include <linux/hrtimer.h>
#include <asm/kvm.h>
#include "iodev.h"
#include "x86.h"

struct kvm;
struct kvm_vcpu;
Expand Down Expand Up @@ -63,8 +64,6 @@ struct kvm_pic {
struct kvm_pic *kvm_create_pic(struct kvm *kvm);
void kvm_pic_set_irq(void *opaque, int irq, int level);
int kvm_pic_read_irq(struct kvm_pic *s);
int kvm_cpu_get_interrupt(struct kvm_vcpu *v);
int kvm_cpu_has_interrupt(struct kvm_vcpu *v);
void kvm_pic_update_irq(struct kvm_pic *s);

#define IOAPIC_NUM_PINS KVM_IOAPIC_NUM_PINS
Expand Down Expand Up @@ -147,6 +146,21 @@ do { \
#define ASSERT(x) do { } while (0)
#endif

static inline struct kvm_pic *pic_irqchip(struct kvm *kvm)
{
return kvm->vpic;
}

static inline struct kvm_ioapic *ioapic_irqchip(struct kvm *kvm)
{
return kvm->vioapic;
}

static inline int irqchip_in_kernel(struct kvm *kvm)
{
return pic_irqchip(kvm) != NULL;
}

void kvm_vcpu_kick(struct kvm_vcpu *vcpu);
int kvm_apic_has_interrupt(struct kvm_vcpu *vcpu);
int kvm_apic_accept_pic_intr(struct kvm_vcpu *vcpu);
Expand Down
18 changes: 3 additions & 15 deletions drivers/kvm/kvm.h
Original file line number Diff line number Diff line change
Expand Up @@ -273,21 +273,6 @@ struct kvm {
struct kvm_vm_stat stat;
};

static inline struct kvm_pic *pic_irqchip(struct kvm *kvm)
{
return kvm->vpic;
}

static inline struct kvm_ioapic *ioapic_irqchip(struct kvm *kvm)
{
return kvm->vioapic;
}

static inline int irqchip_in_kernel(struct kvm *kvm)
{
return pic_irqchip(kvm) != NULL;
}

/* The guest did something we don't support. */
#define pr_unimpl(vcpu, fmt, ...) \
do { \
Expand Down Expand Up @@ -417,6 +402,9 @@ void kvm_free_physmem(struct kvm *kvm);
struct kvm *kvm_arch_create_vm(void);
void kvm_arch_destroy_vm(struct kvm *kvm);

int kvm_cpu_get_interrupt(struct kvm_vcpu *v);
int kvm_cpu_has_interrupt(struct kvm_vcpu *v);

static inline void kvm_guest_enter(void)
{
account_system_vtime(current);
Expand Down
1 change: 0 additions & 1 deletion drivers/kvm/x86.h
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
#define KVM_X86_H

#include "kvm.h"
#include "irq.h"

#include <linux/types.h>
#include <linux/mm.h>
Expand Down

0 comments on commit 682c59a

Please sign in to comment.