Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 99211
b: refs/heads/master
c: 89abd0a
h: refs/heads/master
i:
  99209: b8aa8fc
  99207: f03ff6c
v: v3
  • Loading branch information
Eric Paris authored and James Morris committed Jul 14, 2008
1 parent a92557d commit 685a458
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 14 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: cea78dc4ca044e9666e8f5d797ec50ab85253e49
refs/heads/master: 89abd0acf0335f3f760a3c0698d43bb1eaa83e44
14 changes: 1 addition & 13 deletions trunk/security/selinux/ss/services.c
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ int selinux_policycap_openperm;
extern const struct selinux_class_perm selinux_class_perm;

static DEFINE_RWLOCK(policy_rwlock);
static DEFINE_MUTEX(load_mutex);

static struct sidtab sidtab;
struct policydb policydb;
Expand Down Expand Up @@ -1453,17 +1452,13 @@ int security_load_policy(void *data, size_t len)
int rc = 0;
struct policy_file file = { data, len }, *fp = &file;

mutex_lock(&load_mutex);

if (!ss_initialized) {
avtab_cache_init();
if (policydb_read(&policydb, fp)) {
mutex_unlock(&load_mutex);
avtab_cache_destroy();
return -EINVAL;
}
if (policydb_load_isids(&policydb, &sidtab)) {
mutex_unlock(&load_mutex);
policydb_destroy(&policydb);
avtab_cache_destroy();
return -EINVAL;
Expand All @@ -1472,7 +1467,6 @@ int security_load_policy(void *data, size_t len)
if (validate_classes(&policydb)) {
printk(KERN_ERR
"SELinux: the definition of a class is incorrect\n");
mutex_unlock(&load_mutex);
sidtab_destroy(&sidtab);
policydb_destroy(&policydb);
avtab_cache_destroy();
Expand All @@ -1482,7 +1476,6 @@ int security_load_policy(void *data, size_t len)
policydb_loaded_version = policydb.policyvers;
ss_initialized = 1;
seqno = ++latest_granting;
mutex_unlock(&load_mutex);
selinux_complete_init();
avc_ss_reset(seqno);
selnl_notify_policyload(seqno);
Expand All @@ -1495,13 +1488,10 @@ int security_load_policy(void *data, size_t len)
sidtab_hash_eval(&sidtab, "sids");
#endif

if (policydb_read(&newpolicydb, fp)) {
mutex_unlock(&load_mutex);
if (policydb_read(&newpolicydb, fp))
return -EINVAL;
}

if (sidtab_init(&newsidtab)) {
mutex_unlock(&load_mutex);
policydb_destroy(&newpolicydb);
return -ENOMEM;
}
Expand Down Expand Up @@ -1549,7 +1539,6 @@ int security_load_policy(void *data, size_t len)
seqno = ++latest_granting;
policydb_loaded_version = policydb.policyvers;
write_unlock_irq(&policy_rwlock);
mutex_unlock(&load_mutex);

/* Free the old policydb and SID table. */
policydb_destroy(&oldpolicydb);
Expand All @@ -1563,7 +1552,6 @@ int security_load_policy(void *data, size_t len)
return 0;

err:
mutex_unlock(&load_mutex);
sidtab_destroy(&newsidtab);
policydb_destroy(&newpolicydb);
return rc;
Expand Down

0 comments on commit 685a458

Please sign in to comment.