Skip to content

Commit

Permalink
Revert "pcm_native.c: remove unused label"
Browse files Browse the repository at this point in the history
This reverts commit 680db01.  The label
is actually used, but hidden behind CONFIG_SND_DEBUG and the horrible
snd_assert() macro.

That macro could probably be improved to be along the lines of

	#define snd_assert(expr, args...) do { if ((void)(expr),0) { args; } } while (0)

or similar to make sure that we always both evaluate 'expr' and parse
'args', but while gcc should optimize it all away, I'm too lazy to
really verify that.  So I'll just admit defeat and will continue to live
with the annoying warning.

Noted-by: Robert P. J. Day <rpjday@crashcourse.ca>
Signed-off-by: Linus "Grr.." Torvalds
  • Loading branch information
Linus Torvalds committed Aug 7, 2008
1 parent f99e8f2 commit 685d87f
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions sound/core/pcm_native.c
Original file line number Diff line number Diff line change
Expand Up @@ -3259,6 +3259,7 @@ static int snd_pcm_fasync(int fd, struct file * file, int on)
runtime = substream->runtime;

err = fasync_helper(fd, file, on, &runtime->fasync);
out:
unlock_kernel();
if (err < 0)
return err;
Expand Down

0 comments on commit 685d87f

Please sign in to comment.