Skip to content

Commit

Permalink
Staging: iio/dac/ad5360.c: signedness bug in ad5360_read_raw()
Browse files Browse the repository at this point in the history
ad5360_get_channel_vref() returns an int and scale_uv should be the
same.  Making it unsigned here breaks the error handling.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Dan Carpenter authored and Greg Kroah-Hartman committed Nov 27, 2011
1 parent 23a3b8c commit 685e010
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/staging/iio/dac/ad5360.c
Original file line number Diff line number Diff line change
Expand Up @@ -371,8 +371,8 @@ static int ad5360_read_raw(struct iio_dev *indio_dev,
long m)
{
struct ad5360_state *st = iio_priv(indio_dev);
unsigned long scale_uv;
unsigned int ofs_index;
int scale_uv;
int ret;

switch (m) {
Expand Down

0 comments on commit 685e010

Please sign in to comment.