Skip to content

Commit

Permalink
V4L/DVB: pvrusb2: Avoid using stack allocated buffers when performing…
Browse files Browse the repository at this point in the history
… USB I/O

Drivers shouldn't assume that the stack is DMA-safe.

[mchehab@redhat.com: fix patch description]
Signed-off-by: Mike Isely <isely@pobox.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Mike Isely authored and Mauro Carvalho Chehab committed Jun 1, 2010
1 parent c641a18 commit 6861800
Showing 1 changed file with 11 additions and 1 deletion.
12 changes: 11 additions & 1 deletion drivers/media/video/pvrusb2/pvrusb2-hdw.c
Original file line number Diff line number Diff line change
Expand Up @@ -4084,12 +4084,20 @@ void pvr2_hdw_device_reset(struct pvr2_hdw *hdw)

void pvr2_hdw_cpureset_assert(struct pvr2_hdw *hdw,int val)
{
char da[1];
char *da;
unsigned int pipe;
int ret;

if (!hdw->usb_dev) return;

da = kmalloc(16, GFP_KERNEL);

if (da == NULL) {
pvr2_trace(PVR2_TRACE_ERROR_LEGS,
"Unable to allocate memory to control CPU reset");
return;
}

pvr2_trace(PVR2_TRACE_INIT,"cpureset_assert(%d)",val);

da[0] = val ? 0x01 : 0x00;
Expand All @@ -4103,6 +4111,8 @@ void pvr2_hdw_cpureset_assert(struct pvr2_hdw *hdw,int val)
"cpureset_assert(%d) error=%d",val,ret);
pvr2_hdw_render_useless(hdw);
}

kfree(da);
}


Expand Down

0 comments on commit 6861800

Please sign in to comment.