Skip to content

Commit

Permalink
rsi: Fixed errors and warnings reported by static code analyzers.
Browse files Browse the repository at this point in the history
Fixed a potential buffer overflow in 'rsi_rates' and a sparse warning
related to difference in endianness in rsi_91x_mgmt.c.

Signed-off-by: Jahnavi Meher <jahnavi.meher@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Jahnavi Meher authored and John W. Linville committed Jun 25, 2014
1 parent 80140b7 commit 688df7e
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions drivers/net/wireless/rsi/rsi_91x_mgmt.c
Original file line number Diff line number Diff line change
Expand Up @@ -1055,7 +1055,8 @@ static int rsi_send_auto_rate_request(struct rsi_common *common)
rate_table_offset = 4;
}

for (ii = 0, jj = 0; ii < ARRAY_SIZE(rsi_rates); ii++) {
for (ii = 0, jj = 0;
ii < (ARRAY_SIZE(rsi_rates) - rate_table_offset); ii++) {
if (rate_bitmap & BIT(ii)) {
selected_rates[jj++] =
(rsi_rates[ii + rate_table_offset].bitrate / 5);
Expand Down Expand Up @@ -1103,7 +1104,7 @@ static int rsi_send_auto_rate_request(struct rsi_common *common)
}

for (; ii < RSI_TBL_SZ; ii++)
auto_rate->supported_rates[ii] = min_rate;
auto_rate->supported_rates[ii] = cpu_to_le16(min_rate);

auto_rate->num_supported_rates = cpu_to_le16(num_supported_rates * 2);
auto_rate->moderate_rate_inx = cpu_to_le16(num_supported_rates / 2);
Expand Down

0 comments on commit 688df7e

Please sign in to comment.