Skip to content

Commit

Permalink
Staging: hv: warn the world of a bug in the release function
Browse files Browse the repository at this point in the history
All device release functions need to do something, if not, it's a bug.
By merely providing an "empty" release function, it gets the kernel to
shut up, but that's not solving the problem at all.  Stick a big fat
WARN_ON(1); in there to get people's attention.


Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Greg Kroah-Hartman committed Sep 15, 2009
1 parent f4266e3 commit 689bf40
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions drivers/staging/hv/vmbus_drv.c
Original file line number Diff line number Diff line change
Expand Up @@ -965,6 +965,11 @@ Desc: Final callback release of the vmbus root device
static void vmbus_bus_release(struct device *device)
{
DPRINT_ENTER(VMBUS_DRV);
/* FIXME */
/* Empty release functions are a bug, or a major sign
* of a problem design, this MUST BE FIXED! */
dev_err(device, "%s needs to be fixed!\n", __func__);
WARN_ON(1);
DPRINT_EXIT(VMBUS_DRV);
}

Expand Down

0 comments on commit 689bf40

Please sign in to comment.