Skip to content

Commit

Permalink
gpio: gpio-mm-lantiq: Use of_property_read_u32
Browse files Browse the repository at this point in the history
Instead of parsing manually the shadow content, use the much simpler
helper of_property_read_u32.

Cc: Alexandre Courbot <gnurou@gmail.com>
Cc: Grant Likely <grant.likely@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: John Crispin <blogic@openwrt.org>
Cc: devicetree@vger.kernel.org
Cc: Mark Rutland <mark.rutland@arm.com>
Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
  • Loading branch information
Ricardo Ribalda Delgado authored and Linus Walleij committed Jan 20, 2015
1 parent f3f26c2 commit 68a99b1
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions drivers/gpio/gpio-mm-lantiq.c
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ static void ltq_mm_save_regs(struct of_mm_gpio_chip *mm_gc)
static int ltq_mm_probe(struct platform_device *pdev)
{
struct ltq_mm *chip;
const __be32 *shadow;
u32 shadow;

chip = devm_kzalloc(&pdev->dev, sizeof(*chip), GFP_KERNEL);
if (!chip)
Expand All @@ -117,9 +117,8 @@ static int ltq_mm_probe(struct platform_device *pdev)
chip->mmchip.save_regs = ltq_mm_save_regs;

/* store the shadow value if one was passed by the devicetree */
shadow = of_get_property(pdev->dev.of_node, "lantiq,shadow", NULL);
if (shadow)
chip->shadow = be32_to_cpu(*shadow);
if (!of_property_read_u32(pdev->dev.of_node, "lantiq,shadow", &shadow))
chip->shadow = shadow;

return of_mm_gpiochip_add(pdev->dev.of_node, &chip->mmchip);
}
Expand Down

0 comments on commit 68a99b1

Please sign in to comment.