Skip to content

Commit

Permalink
net: skge: remove unnecessary pci_set_drvdata()
Browse files Browse the repository at this point in the history
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Jingoo Han authored and David S. Miller committed Oct 21, 2013
1 parent 54fe902 commit 68e35d8
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions drivers/net/ethernet/marvell/skge.c
Original file line number Diff line number Diff line change
Expand Up @@ -4046,7 +4046,6 @@ static int skge_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
pci_release_regions(pdev);
err_out_disable_pdev:
pci_disable_device(pdev);
pci_set_drvdata(pdev, NULL);
err_out:
return err;
}
Expand Down Expand Up @@ -4090,7 +4089,6 @@ static void skge_remove(struct pci_dev *pdev)

iounmap(hw->regs);
kfree(hw);
pci_set_drvdata(pdev, NULL);
}

#ifdef CONFIG_PM_SLEEP
Expand Down

0 comments on commit 68e35d8

Please sign in to comment.