Skip to content

Commit

Permalink
[PATCH] hci_{read,write}l() does force casts to wrong type for no reason
Browse files Browse the repository at this point in the history
readl() et.al. expect iomem pointer, so WTF force-cast it to normal one???

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Al Viro authored and Linus Torvalds committed Feb 9, 2007
1 parent 53ebb3b commit 68f50e5
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 12 deletions.
12 changes: 6 additions & 6 deletions drivers/usb/host/ehci.h
Original file line number Diff line number Diff line change
Expand Up @@ -677,10 +677,10 @@ static inline unsigned int ehci_readl (const struct ehci_hcd *ehci,
{
#ifdef CONFIG_USB_EHCI_BIG_ENDIAN_MMIO
return ehci_big_endian_mmio(ehci) ?
readl_be((__force u32 *)regs) :
readl((__force u32 *)regs);
readl_be(regs) :
readl(regs);
#else
return readl((__force u32 *)regs);
return readl(regs);
#endif
}

Expand All @@ -689,10 +689,10 @@ static inline void ehci_writel (const struct ehci_hcd *ehci,
{
#ifdef CONFIG_USB_EHCI_BIG_ENDIAN_MMIO
ehci_big_endian_mmio(ehci) ?
writel_be(val, (__force u32 *)regs) :
writel(val, (__force u32 *)regs);
writel_be(val, regs) :
writel(val, regs);
#else
writel(val, (__force u32 *)regs);
writel(val, regs);
#endif
}

Expand Down
12 changes: 6 additions & 6 deletions drivers/usb/host/ohci.h
Original file line number Diff line number Diff line change
Expand Up @@ -507,10 +507,10 @@ static inline unsigned int _ohci_readl (const struct ohci_hcd *ohci,
{
#ifdef CONFIG_USB_OHCI_BIG_ENDIAN_MMIO
return big_endian_mmio(ohci) ?
readl_be ((__force u32 *)regs) :
readl ((__force u32 *)regs);
readl_be (regs) :
readl (regs);
#else
return readl ((__force u32 *)regs);
return readl (regs);
#endif
}

Expand All @@ -519,10 +519,10 @@ static inline void _ohci_writel (const struct ohci_hcd *ohci,
{
#ifdef CONFIG_USB_OHCI_BIG_ENDIAN_MMIO
big_endian_mmio(ohci) ?
writel_be (val, (__force u32 *)regs) :
writel (val, (__force u32 *)regs);
writel_be (val, regs) :
writel (val, regs);
#else
writel (val, (__force u32 *)regs);
writel (val, regs);
#endif
}

Expand Down

0 comments on commit 68f50e5

Please sign in to comment.