Skip to content

Commit

Permalink
checkpatch: add checks for in_atomic()
Browse files Browse the repository at this point in the history
in_atomic() is not for driver use so report any such use as an ERROR.
Also in_atomic() is often used to determine if we may sleep, but it is not
reliable in this use model therefore strongly discourage its use.

Signed-off-by: Andy Whitcroft <apw@shadowen.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Andy Whitcroft authored and Linus Torvalds committed Jan 6, 2009
1 parent 94e2959 commit 691d77b
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions scripts/checkpatch.pl
Original file line number Diff line number Diff line change
Expand Up @@ -2466,6 +2466,15 @@ sub process {
last;
}
}

# whine mightly about in_atomic
if ($line =~ /\bin_atomic\s*\(/) {
if ($realfile =~ m@^drivers/@) {
ERROR("do not use in_atomic in drivers\n" . $herecurr);
} else {
WARN("use of in_atomic() is incorrect outside core kernel code\n" . $herecurr);
}
}
}

# If we have no input at all, then there is nothing to report on
Expand Down

0 comments on commit 691d77b

Please sign in to comment.