Skip to content

Commit

Permalink
ASoC: Improve DAPM pop_wait delays
Browse files Browse the repository at this point in the history
Currently during pop/click debug we're inserting a delay both after
every log message we generate and at explicit points in the sequence,
slowing things down even further than they need to be especially when
many writes get coalesced by the sequence generation code.

Remove the per-printk delay and ensure that we have explicit delays
where we say we want them.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
  • Loading branch information
Mark Brown committed Mar 5, 2010
1 parent 1d24452 commit 6922471
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions sound/soc/soc-dapm.c
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,6 @@ static void pop_dbg(u32 pop_time, const char *fmt, ...)

if (pop_time) {
vprintk(fmt, args);
pop_wait(pop_time);
}

va_end(args);
Expand Down Expand Up @@ -314,8 +313,8 @@ static int dapm_update_bits(struct snd_soc_dapm_widget *widget)
pop_dbg(codec->pop_time, "pop test %s : %s in %d ms\n",
widget->name, widget->power ? "on" : "off",
codec->pop_time);
snd_soc_write(codec, widget->reg, new);
pop_wait(codec->pop_time);
snd_soc_write(codec, widget->reg, new);
}
pr_debug("reg %x old %x new %x change %d\n", widget->reg,
old, new, change);
Expand Down Expand Up @@ -1075,6 +1074,7 @@ static int dapm_power_widgets(struct snd_soc_codec *codec, int event)

pop_dbg(codec->pop_time, "DAPM sequencing finished, waiting %dms\n",
codec->pop_time);
pop_wait(codec->pop_time);

return 0;
}
Expand Down

0 comments on commit 6922471

Please sign in to comment.