Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 327548
b: refs/heads/master
c: fc07393
h: refs/heads/master
v: v3
  • Loading branch information
Ying Xue authored and David S. Miller committed Aug 20, 2012
1 parent 784f8bd commit 69618c9
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 13 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 4225a398c1352a7a5c14dc07277cb5cc4473983b
refs/heads/master: fc0739385ba10f59105e87a46cc93d9d9a10553c
6 changes: 2 additions & 4 deletions trunk/net/tipc/bearer.c
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ static int media_name_valid(const char *name)
len = strlen(name);
if ((len + 1) > TIPC_MAX_MEDIA_NAME)
return 0;
return strspn(name, tipc_alphabet) == len;
return 1;
}

/**
Expand Down Expand Up @@ -206,9 +206,7 @@ static int bearer_name_validate(const char *name,

/* validate component parts of bearer name */
if ((media_len <= 1) || (media_len > TIPC_MAX_MEDIA_NAME) ||
(if_len <= 1) || (if_len > TIPC_MAX_IF_NAME) ||
(strspn(media_name, tipc_alphabet) != (media_len - 1)) ||
(strspn(if_name, tipc_alphabet) != (if_len - 1)))
(if_len <= 1) || (if_len > TIPC_MAX_IF_NAME))
return 0;

/* return bearer name components, if necessary */
Expand Down
3 changes: 0 additions & 3 deletions trunk/net/tipc/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,6 @@
/* global variables used by multiple sub-systems within TIPC */
int tipc_random;

const char tipc_alphabet[] =
"ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789_.";

/* configurable TIPC parameters */
u32 tipc_own_addr;
int tipc_max_ports;
Expand Down
2 changes: 0 additions & 2 deletions trunk/net/tipc/core.h
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,6 @@ extern int tipc_remote_management;
* Other global variables
*/
extern int tipc_random;
extern const char tipc_alphabet[];


/*
* Routines available to privileged subsystems
Expand Down
4 changes: 1 addition & 3 deletions trunk/net/tipc/link.c
Original file line number Diff line number Diff line change
Expand Up @@ -210,9 +210,7 @@ static int link_name_validate(const char *name,
(z_local > 255) || (c_local > 4095) || (n_local > 4095) ||
(z_peer > 255) || (c_peer > 4095) || (n_peer > 4095) ||
(if_local_len <= 1) || (if_local_len > TIPC_MAX_IF_NAME) ||
(if_peer_len <= 1) || (if_peer_len > TIPC_MAX_IF_NAME) ||
(strspn(if_local, tipc_alphabet) != (if_local_len - 1)) ||
(strspn(if_peer, tipc_alphabet) != (if_peer_len - 1)))
(if_peer_len <= 1) || (if_peer_len > TIPC_MAX_IF_NAME))
return 0;

/* return link name components, if necessary */
Expand Down

0 comments on commit 69618c9

Please sign in to comment.