Skip to content

Commit

Permalink
p54spi: cosmetic fixes: use even byte count in SPI write; drop unused…
Browse files Browse the repository at this point in the history
… interrupt status read

When SPI write of odd length is requested, p54spi_write splits it
into two parts: one for all data, except the last byte, and one
for last byte and padding byte. Unfortunately, the length of
first part is not amended. It works because all meaningful bytes
have proper value and the last byte of odd length SPI write
transaction is ignored.

p54spi_work has dummy HOST_INTERRUPTS register read at the end.
Drop it, as its result is not used and it has no side effects.

Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Max Filippov authored and John W. Linville committed May 20, 2009
1 parent 210dd1b commit 69712e9
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions drivers/net/wireless/p54/p54spi.c
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ static void p54spi_spi_write(struct p54s_priv *priv, u8 address,
spi_message_add_tail(&t[0], &m);

t[1].tx_buf = buf;
t[1].len = len;
t[1].len = len & ~1;
spi_message_add_tail(&t[1], &m);

if (len % 2) {
Expand Down Expand Up @@ -541,11 +541,6 @@ static void p54spi_work(struct work_struct *work)
}

ret = p54spi_wq_tx(priv);
if (ret < 0)
goto out;

ints = p54spi_read32(priv, SPI_ADRS_HOST_INTERRUPTS);

out:
mutex_unlock(&priv->mutex);
}
Expand Down

0 comments on commit 69712e9

Please sign in to comment.