Skip to content

Commit

Permalink
[PATCH] isdn4linux: Gigaset driver cleanup
Browse files Browse the repository at this point in the history
The following patch to the common part of the Siemens Gigaset driver
prevents it from trying to send the +++ break sequence if the device has
been disconnected, and removes a couple of assignments which didn't have
any effect.

Signed-off-by: Tilman Schmidt <tilman@imap.cc>
Acked-by: Hansjoerg Lipp <hjlipp@web.de>
Cc: Karsten Keil <kkeil@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Tilman Schmidt authored and Linus Torvalds committed Jun 26, 2006
1 parent 06163f8 commit 698e3ed
Showing 1 changed file with 4 additions and 9 deletions.
13 changes: 4 additions & 9 deletions drivers/isdn/gigaset/ev-layer.c
Original file line number Diff line number Diff line change
Expand Up @@ -1262,7 +1262,8 @@ static void do_action(int action, struct cardstate *cs,
break;
case ACT_HUPMODEM:
/* send "+++" (hangup in unimodem mode) */
cs->ops->write_cmd(cs, "+++", 3, NULL);
if (cs->connected)
cs->ops->write_cmd(cs, "+++", 3, NULL);
break;
case ACT_RING:
/* get fresh AT state structure for new CID */
Expand Down Expand Up @@ -1294,7 +1295,6 @@ static void do_action(int action, struct cardstate *cs,
break;
case ACT_ICALL:
handle_icall(cs, bcs, p_at_state);
at_state = *p_at_state;
break;
case ACT_FAILSDOWN:
dev_warn(cs->dev, "Could not shut down the device.\n");
Expand Down Expand Up @@ -1334,10 +1334,8 @@ static void do_action(int action, struct cardstate *cs,
*/
at_state->pending_commands |= PC_DLE0;
atomic_set(&cs->commands_pending, 1);
} else {
} else
disconnect(p_at_state);
at_state = *p_at_state;
}
break;
case ACT_FAKEDLE0:
at_state->int_var[VAR_ZDLE] = 0;
Expand All @@ -1354,10 +1352,8 @@ static void do_action(int action, struct cardstate *cs,
at_state->cid = -1;
if (bcs && cs->onechannel)
at_state->pending_commands |= PC_DLE0;
else {
else
disconnect(p_at_state);
at_state = *p_at_state;
}
schedule_init(cs, MS_RECOVER);
break;
case ACT_FAILDLE0:
Expand Down Expand Up @@ -1410,7 +1406,6 @@ static void do_action(int action, struct cardstate *cs,

case ACT_ABORTACCEPT: /* hangup/error/timeout during ICALL processing */
disconnect(p_at_state);
at_state = *p_at_state;
break;

case ACT_ABORTDIAL: /* error/timeout during dial preparation */
Expand Down

0 comments on commit 698e3ed

Please sign in to comment.