Skip to content

Commit

Permalink
[media] solo6x10: disable the 'priv' abuse
Browse files Browse the repository at this point in the history
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Hans Verkuil authored and Mauro Carvalho Chehab committed Mar 25, 2013
1 parent 15513c1 commit 6999687
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions drivers/staging/media/solo6x10/v4l2-enc.c
Original file line number Diff line number Diff line change
Expand Up @@ -860,8 +860,16 @@ static int solo_enc_set_fmt_cap(struct file *file, void *priv,
/* This does not change the encoder at all */
solo_enc->fmt = pix->pixelformat;

/*
* More information is needed about these 'extended' types. As far
* as I can tell these are basically additional video streams with
* different MPEG encoding attributes that can run in parallel with
* the main stream. If so, then this should be implemented as a
* second video node. Abusing priv like this is certainly not the
* right approach.
if (pix->priv)
solo_enc->type = SOLO_ENC_TYPE_EXT;
*/
return 0;
}

Expand Down

0 comments on commit 6999687

Please sign in to comment.